IO#gets failures with latest rubyspecs (tainting, lineno, $.)
-------------------------------------------------------------
Key: JRUBY-2075
URL: http://jira.codehaus.org/browse/JRUBY-2075
Project: JRuby
Issue Type: Bug
Components: Core Classes/Modules
Affects Versions: JRuby 1.1RC1
Environment: Latest JRuby 1.1RC1
Reporter: Vladimir Sizikov
Assignee: Vladimir Sizikov
Fix For: JRuby 1.1RC2
JRuby fails the following (recently added by me) rubyspecs for IO#gets and
IO#foreach, related to tainting, lineno and $. :
{noformat}
bin/mspec -t j spec/ruby/1.8/core/io/foreach_spec.rb
spec/ruby/1.8/core/io/gets_spec.rb
Started
...F......FFF.......
1)
IO::foreach updates $. with each yield FAILED
Expected 1 to equal 2:
./mspec/expectations.rb:10:in `fail_with'
./mspec/matchers/base.rb:19:in `=='
/opt/work/rubinius/./spec/ruby/1.8/core/io/foreach_spec.rb:57
/opt/work/rubinius/./spec/ruby/1.8/core/io/foreach_spec.rb:56:in `foreach'
/opt/work/rubinius/./spec/ruby/1.8/core/io/foreach_spec.rb:56
/opt/work/rubinius/./spec/ruby/1.8/core/io/foreach_spec.rb:56:in `call'
./mspec/runner/runner.rb:136:in `describe'
./mspec/runner/runner.rb:135:in `each'
./mspec/runner/runner.rb:130:in `describe'
./mspec/runner/runner.rb:135:in `describe'
/opt/work/rubinius/./spec/ruby/1.8/core/io/foreach_spec.rb:3
/opt/work/rubinius/./spec/ruby/1.8/core/io/foreach_spec.rb:3:in `load'
tmp/last_mspec.rb:15
tmp/last_mspec.rb:10:in `each'
tmp/last_mspec.rb:10
2)
IO#gets returns tainted strings FAILED
Expected false to equal true:
./mspec/expectations.rb:10:in `fail_with'
./mspec/matchers/base.rb:20:in `=='
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:24
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:22:in `open'
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:22
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:22:in `call'
./mspec/runner/runner.rb:136:in `describe'
./mspec/runner/runner.rb:135:in `each'
./mspec/runner/runner.rb:130:in `describe'
./mspec/runner/runner.rb:135:in `describe'
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:4
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:4:in `load'
tmp/last_mspec.rb:15
tmp/last_mspec.rb:10:in `each'
tmp/last_mspec.rb:10
3)
IO#gets updates lineno with each invocation FAILED
Expected 0 to equal 1:
./mspec/expectations.rb:10:in `fail_with'
./mspec/matchers/base.rb:20:in `=='
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:45
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:43:in `open'
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:43
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:43:in `call'
./mspec/runner/runner.rb:136:in `describe'
./mspec/runner/runner.rb:135:in `each'
./mspec/runner/runner.rb:130:in `describe'
./mspec/runner/runner.rb:135:in `describe'
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:4
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:4:in `load'
tmp/last_mspec.rb:15
tmp/last_mspec.rb:10:in `each'
tmp/last_mspec.rb:10
4)
IO#gets updates $. with each invocation FAILED
Expected 1 to equal 2:
./mspec/expectations.rb:10:in `fail_with'
./mspec/matchers/base.rb:20:in `=='
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:87
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:85:in `open'
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:85
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:85:in `call'
./mspec/runner/runner.rb:136:in `describe'
./mspec/runner/runner.rb:135:in `each'
./mspec/runner/runner.rb:130:in `describe'
./mspec/runner/runner.rb:135:in `describe'
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:4
/opt/work/rubinius/./spec/ruby/1.8/core/io/gets_spec.rb:4:in `load'
tmp/last_mspec.rb:15
tmp/last_mspec.rb:10:in `each'
tmp/last_mspec.rb:10
Finished in 0.162000 seconds
20 examples, 49 expectations, 4 failures, 0 errors
{noformat}
Fix is coming.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
