Major regression in Array#pack
------------------------------
Key: JRUBY-2502
URL: http://jira.codehaus.org/browse/JRUBY-2502
Project: JRuby
Issue Type: Bug
Components: Core Classes/Modules
Affects Versions: JRuby 1.1+
Environment: Latest JRuby 1.1.1+, bulit from trunk, rev r6650
Reporter: Vladimir Sizikov
Priority: Blocker
Fix For: JRuby 1.1.2
Revisions r6649 and r6650 introduced a bunch of major regressions in
Array#pack:
The following examples crash JRuby (and crash the rubyspec run!):
{noformat}
s = ["ABC"*31].pack('m')
s = ["A"*50].pack('u')
{noformat}
The stack trace:
{noformat}
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 91
at org.jruby.util.Pack.encodes(Pack.java:306)
at org.jruby.util.Pack.pack(Pack.java:1777)
at org.jruby.RubyArray.pack(RubyArray.java:2339)
at org.jruby.RubyArrayInvoker$pack_method_1_0.call(Unknown Source)
{noformat}
Plus, once those problematic places that crash JRuby commented out, there are
still three more rubyspec failures:
{noformat}
bin/mspec run -f m -t j spec/ruby/1.8/core/array/pack_spec.rb
1)
Array#pack enocdes string with Qouted Printable encoding with ('M') FAILED
Expected "ABCDEF=00=00=00=\n"
to equal "ABCDEF=\n"
/opt/work/rbx.git/mspec/lib/mspec/expectations/expectations.rb:10:in `fail_with'
/opt/work/rbx.git/mspec/lib/mspec/matchers/base.rb:9:in `=='
/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb:427:in
`/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:120:in `call'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:120:in `protect'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:46:in `each'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:46:in `protect'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:60:in `process'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:56:in `each'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:56:in `process'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:27:in `describe'
/opt/work/rbx.git/mspec/lib/mspec/runner/object.rb:11:in `describe'
/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb:9:in
`/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb'
/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb:45:in `load'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:45:in `files'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:120:in `call'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:120:in `protect'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:45:in `files'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:42:in `each'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:42:in `files'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:34:in `process'
mspec/bin/mspec-run:76:in `run'
/opt/work/rbx.git/mspec/lib/mspec/utils/script.rb:75:in `main'
mspec/bin/mspec-run:83
2)
Array#pack doesn't encode new line chars with ('M') FAILED
Expected "\nA=00=\n"
to equal "\nA=\n"
/opt/work/rbx.git/mspec/lib/mspec/expectations/expectations.rb:10:in `fail_with'
/opt/work/rbx.git/mspec/lib/mspec/matchers/base.rb:9:in `=='
/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb:431:in
`/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:120:in `call'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:120:in `protect'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:46:in `each'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:46:in `protect'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:60:in `process'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:56:in `each'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:56:in `process'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:27:in `describe'
/opt/work/rbx.git/mspec/lib/mspec/runner/object.rb:11:in `describe'
/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb:9:in
`/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb'
/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb:45:in `load'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:45:in `files'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:120:in `call'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:120:in `protect'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:45:in `files'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:42:in `each'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:42:in `files'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:34:in `process'
mspec/bin/mspec-run:76:in `run'
/opt/work/rbx.git/mspec/lib/mspec/utils/script.rb:75:in `main'
mspec/bin/mspec-run:83
3)
Array#pack calls to_s on object to convert to string with ('M') FAILED
Expected "unnamed object=00=00=00=00=00=00=00=\n"
to equal "unnamed object=\n"
/opt/work/rbx.git/mspec/lib/mspec/expectations/expectations.rb:10:in `fail_with'
/opt/work/rbx.git/mspec/lib/mspec/matchers/base.rb:9:in `=='
/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb:478:in
`/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:120:in `call'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:120:in `protect'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:46:in `each'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:46:in `protect'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:60:in `process'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:56:in `each'
/opt/work/rbx.git/mspec/lib/mspec/runner/state.rb:56:in `process'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:27:in `describe'
/opt/work/rbx.git/mspec/lib/mspec/runner/object.rb:11:in `describe'
/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb:9:in
`/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb'
/opt/work/rbx.git/./spec/ruby/1.8/core/array/pack_spec.rb:45:in `load'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:45:in `files'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:120:in `call'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:120:in `protect'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:45:in `files'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:42:in `each'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:42:in `files'
/opt/work/rbx.git/mspec/lib/mspec/runner/mspec.rb:34:in `process'
mspec/bin/mspec-run:76:in `run'
/opt/work/rbx.git/mspec/lib/mspec/utils/script.rb:75:in `main'
mspec/bin/mspec-run:83
Finished in 0.478000 seconds
1 file, 155 examples, 358 expectations, 3 failures, 0 errors
{noformat}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
