Hash.[] should call to_hash if only one argument is provided
------------------------------------------------------------
Key: JRUBY-2585
URL: http://jira.codehaus.org/browse/JRUBY-2585
Project: JRuby
Issue Type: Bug
Components: Core Classes/Modules
Affects Versions: JRuby 1.1.2
Environment: Latest JRuby 1.1.2
Reporter: Vladimir Sizikov
Assignee: Vladimir Sizikov
Fix For: JRuby 1.1.3
If only a single parameter is provided for Hash[parameter], JRuby should call
to_hash method on that parameter.
Note, that MRI 1.8.6 has a known bug and doesn't do that, but MRI 1.7 and up do.
{noformat}
o = Object.new
def o.to_hash; {:a=>:b}; end
Hash[o] # => {:a=>:b}
{noformat}
This also leads to one rubyspec failure:
{noformat}
mspec run -t j spec/ruby/1.8/core/hash/element_reference_spec.rb
...E............
1)
Hash.[] call to_hash ERROR
ArgumentError: odd number of args for Hash
/opt/work/./spec/ruby/1.8/core/hash/element_reference_spec.rb:26:in `[]'
/opt/work/./spec/ruby/1.8/core/hash/element_reference_spec.rb:26:in
`/opt/work/./spec/ruby/1.8/core/hash/element_reference_spec.rb'
/opt/work/mspec.git/lib/mspec/runner/mspec.rb:120:in `instance_eval'
/opt/work/mspec.git/lib/mspec/runner/mspec.rb:120:in `protect'
/opt/work/mspec.git/lib/mspec/runner/state.rb:46:in `each'
/opt/work/mspec.git/lib/mspec/runner/state.rb:46:in `protect'
/opt/work/mspec.git/lib/mspec/runner/state.rb:60:in `process'
/opt/work/mspec.git/lib/mspec/runner/state.rb:56:in `each'
/opt/work/mspec.git/lib/mspec/runner/state.rb:56:in `process'
/opt/work/mspec.git/lib/mspec/runner/mspec.rb:27:in `describe'
/opt/work/mspec.git/lib/mspec/runner/object.rb:11:in `describe'
/opt/work/./spec/ruby/1.8/core/hash/element_reference_spec.rb:4:in
`/opt/work/./spec/ruby/1.8/core/hash/element_reference_spec.rb'
/opt/work/./spec/ruby/1.8/core/hash/element_reference_spec.rb:45:in `load'
/opt/work/mspec.git/lib/mspec/runner/mspec.rb:45:in `files'
/opt/work/mspec.git/lib/mspec/runner/mspec.rb:120:in `instance_eval'
/opt/work/mspec.git/lib/mspec/runner/mspec.rb:120:in `protect'
/opt/work/mspec.git/lib/mspec/runner/mspec.rb:45:in `files'
/opt/work/mspec.git/lib/mspec/runner/mspec.rb:42:in `each'
/opt/work/mspec.git/lib/mspec/runner/mspec.rb:42:in `files'
/opt/work/mspec.git/lib/mspec/runner/mspec.rb:34:in `process'
/opt/work/mspec.git/bin/mspec-ci:68:in `run'
/opt/work/mspec.git/lib/mspec/utils/script.rb:75:in `main'
/opt/work/mspec.git/bin/mspec-ci:75
Finished in 0.179000 seconds
1 file, 16 examples, 41 expectations, 0 failures, 1 error
{noformat}
Fix is coming.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
