On Fri, Aug 29, 2008 at 5:31 AM, Martin Krauskopf <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: >> >> Revision >> 7507 <http://fisheye.codehaus.org/changelog/jruby/?cs=7507> >> Author >> enebo >> Date >> 2008-08-20 17:36:35 -0500 (Wed, 20 Aug 2008) >> >> >> Log Message >> >> Change Events to be based on enum to better encapsulate line offset logic >> (path by Jay McGaffigan w/ mild tweaks by me) > > [...] > > I've just found out that JRuby 1.1.4 breaks the debugger. EventHook was > changed from interface to abstract class (API breakage), that's not good, > but... OK, <nitpick>kind of tradition</nitpick> ;) > > What I did not get, is why API clients are given event's name instead of the > enum type (RubyEvent) itself. I thought that one advantage of migrating > would be more type-safety with type-safe enumeration on the client-side, but > that has not changed. Before the change, the client had to check against > 'int', now it is a 'String' with EventHook#eventHandler. > > Knowing the underlaying JRuby code one could cheat overriding > EventHook#event and implementing dummy/empty EventHook#eventHandler, but > that's not a good solution. > > So I suggest to change the EventHook#eventHandler signature for JRuby 1.1.5 > to pass RubyEvent instead of piece of it. > > Might be I've missed something. > > Sorry for bringing this too late, but I did not see any pre-announcement > about JRuby 1.1.4, so I could check it before the release. Might be I've > just missed it.
Sorry Martin, this was my fault. The patch I received was passing event hook as an enum, but was also passing the line number adjusted from the enum before calling the event method. The signature should probably pass the unadjusted line number and the enum in. I changed it at the last moment to be a string. Also sorry about the interface, I guess I should have realized that was used externally. Since I broke this for 1.1.4 maybe we re-break for 1.1.5 and get this set up correctly. We can then lock-step upgrade debugging with jruby? -Tom -- Blog: http://www.bloglines.com/blog/ThomasEEnebo Email: [EMAIL PROTECTED] , [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
