[PATCH] Fix for ShellLauncher.shouldRunInProcess not being strict enough
------------------------------------------------------------------------
Key: JRUBY-3022
URL: http://jira.codehaus.org/browse/JRUBY-3022
Project: JRuby
Issue Type: Improvement
Components: Core Classes/Modules
Affects Versions: JRuby 1.1.4
Reporter: Michael Guterl
Attachments:
0001-made-ShellLauncher.shouldRunInProcess-more-strict-i.patch
ShellLauncher.shouldRunInProcess checks the command string for certain
characters that indicate if the command should be executed in the shell. The
current version only checks for <, >, and |. Based off of the regexp used in
MRI, I have modified this function to take these additional characters into
account.
On a side note, I think there should be a more accurate rubyspec for this
behavior, which is something I am working on. The documentation on
Kernel.system() states that when only a string is passed to system() that any
shell variables will be expanded. As a result of the loose checking of the
string, this behavior was not present prior to this patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
