Lars Westergren wrote:
Hi,
I thought Ola mentioned that he had fixed all the recursive array.eql?
bugs, when I check out and update ruby-187 with "git pull", build, and
then run the following command -
./bin/jruby spec/mspec/bin/mspec spec/ruby/core/array/
It still fails for me at exactly the same places as before, for instance:
Array#eql? handles well recursive arrays FAILED
Expected false to be true
/home/larsw/jruby/src/jruby-187/spec/mspec/lib/mspec/expectations/expectations.rb:15:in
`fail_with'
/home/larsw/jruby/src/jruby-187/spec/mspec/lib/mspec/expectations/should.rb:7:in
`should'
/home/larsw/jruby/src/jruby-187/spec/ruby/core/array/shared/eql.rb:32
Are all the changes not checked in yet, or have I missed doing something?
Cheers,
Lars
You misunderstood my meaning. I explained this in the JIRA I closed for
this.
These specs are failing right now because they need to - to make them
pass would be incompatible compared to 1.8.7. Since I didn't get any
good consensus on whether we should scrap bug-compatibility I decided to
not fix these. You can see that if you look in our tags
(spec/tags/ruby/core/array/eql_tags.txt in this case), where I've noted
all the bugs that are there for 1.8.7 compatibility.
Cheers
--
Ola Bini (http://olabini.com)
Ioke creator (http://ioke.org)
JRuby Core Developer (http://jruby.org)
Developer, ThoughtWorks Studios (http://studios.thoughtworks.com)
Practical JRuby on Rails (http://apress.com/book/view/9781590598818)
"Yields falsehood when quined" yields falsehood when quined.
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
