On Fri, Oct 16, 2009 at 1:02 PM, Yoko Harada <[email protected]> wrote:
> On Wed, Oct 14, 2009 at 5:57 PM, Yoko Harada <[email protected]> wrote:
>> META-INF/services/javax.script.ScriptEngineFactory is missing in a
>> compiled archive. I'm trying to find a way to add this.
>
> Let me ask this change is reasonable or not since this is the first
> time to edit JRuby's build.xml.
>
> To put META-INF/services/javax.script.ScriptEngineFactory in jar
> archive, I added metainf element below to each jar and jarjar task.
> Four places in total.
>
> <metainf dir="${base.dir}/spi">
> <include name="services/**"/>
> </metainf>
>
> Plus, I made new directory, "spi," in JRuby's top directory. In the
> subdirectory of spi, services/javax.script.ScriptEngineFactory is
> there.
>
> jruby~main
> + COPYING
> + COPYING.CPL
> ...
> + spec + ...
> + spi + services + javax.script.ScriptEngineFactory
> + src + ...
> ...
>
> Built archive has META-INF below:
>
> electra:jruby~main yoko$ jar tvf lib/jruby.jar |grep META-INF| sort -k 8
> 0 Fri Oct 16 13:18:20 EDT 2009 META-INF/
> 11560 Tue Dec 04 21:23:08 EST 2007 META-INF/LICENSE.txt
> 21554 Fri Oct 16 13:18:20 EDT 2009 META-INF/MANIFEST.MF
> 316 Tue Dec 04 21:23:08 EST 2007 META-INF/NOTICE.txt
> 0 Fri Oct 16 13:18:20 EDT 2009 META-INF/maven/
> 0 Fri Oct 16 13:18:20 EDT 2009 META-INF/maven/jline/
> 0 Fri Oct 16 13:18:20 EDT 2009 META-INF/maven/jline/jline/
> 96 Tue Nov 13 00:49:24 EST 2007 META-INF/maven/jline/jline/pom.properties
> 6359 Tue Nov 13 00:45:44 EST 2007 META-INF/maven/jline/jline/pom.xml
> 0 Fri Oct 16 13:18:20 EDT 2009 META-INF/maven/org.jruby.ext.posix/
> 0 Fri Oct 16 13:18:20 EDT 2009
> META-INF/maven/org.jruby.ext.posix/jnr-posix/
> 113 Fri Oct 09 09:16:38 EDT 2009
> META-INF/maven/org.jruby.ext.posix/jnr-posix/pom.properties
> 3812 Fri Oct 09 09:08:02 EDT 2009
> META-INF/maven/org.jruby.ext.posix/jnr-posix/pom.xml
> 0 Fri Oct 16 13:18:20 EDT 2009 META-INF/maven/org.jruby.extras/
> 0 Fri Oct 16 13:18:20 EDT 2009 META-INF/maven/org.jruby.extras/bytelist/
> 109 Thu Apr 30 15:40:12 EDT 2009
> META-INF/maven/org.jruby.extras/bytelist/pom.properties
> 3078 Thu Apr 30 15:37:10 EDT 2009
> META-INF/maven/org.jruby.extras/bytelist/pom.xml
> 0 Fri Oct 16 13:18:20 EDT 2009
> META-INF/maven/org.jruby.extras/constantine/
> 110 Sun May 31 10:05:14 EDT 2009
> META-INF/maven/org.jruby.extras/constantine/pom.properties
> 3228 Sun May 31 10:03:06 EDT 2009
> META-INF/maven/org.jruby.extras/constantine/pom.xml
> 0 Fri Oct 16 13:18:20 EDT 2009 META-INF/maven/org.jruby.extras/jaffl/
> 106 Fri Oct 09 08:58:30 EDT 2009
> META-INF/maven/org.jruby.extras/jaffl/pom.properties
> 5484 Fri Oct 09 08:57:30 EDT 2009
> META-INF/maven/org.jruby.extras/jaffl/pom.xml
> 0 Fri Oct 16 13:18:20 EDT 2009 META-INF/maven/org.jruby.jcodings/
> 0 Fri Oct 16 13:18:20 EDT 2009 META-INF/maven/org.jruby.jcodings/jcodings/
> 116 Tue Feb 24 21:37:50 EST 2009
> META-INF/maven/org.jruby.jcodings/jcodings/pom.properties
> 3111 Tue Feb 24 21:34:44 EST 2009
> META-INF/maven/org.jruby.jcodings/jcodings/pom.xml
> 0 Fri Oct 16 13:18:20 EDT 2009 META-INF/maven/org.jruby.joni/
> 0 Fri Oct 16 13:18:20 EDT 2009 META-INF/maven/org.jruby.joni/joni/
> 108 Tue Feb 24 18:44:36 EST 2009
> META-INF/maven/org.jruby.joni/joni/pom.properties
> 3774 Tue Feb 24 18:39:06 EST 2009 META-INF/maven/org.jruby.joni/joni/pom.xml
> 0 Fri Oct 16 13:18:20 EDT 2009 META-INF/services/
> 42 Wed Sep 16 13:39:46 EDT 2009
> META-INF/services/javax.script.ScriptEngineFactory
Sounds good to me.
> I think every info that must be in META-INF is included, but I
> appreciate somebody check this.
>
> I have one more question about jar-jruby-light target. Before
> zipfilelist of jruby-embed.jar was not listed in this target, but now
> org.jruby.embed is included in jruby-light.jar. Should I add metainf
> element in this target? Or,should <exclude
> name="org/jruby/embed/**/*"/> be added?
I'm not sure we really use the jar-jruby-light target at all, or if
anyone has any plans for it. For now, the simplest would be to add the
exclude, but I'm wondering whether we need to keep the target at all.
/Nick
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
