Yecht is setTaint'ing Ruby immediate objects.
---------------------------------------------
Key: JRUBY-4113
URL: http://jira.codehaus.org/browse/JRUBY-4113
Project: JRuby
Issue Type: Bug
Affects Versions: JRuby 1.4.0RC1
Reporter: Thomas E Enebo
Assignee: Ola Bini
For now I put in some code in RubyBasicObject.setTaint to ignore tainting on
immediate objects, but ultimately no consumers should try to taint an immediate
object. When Yecht applies the following patch, then the extra if conditional
we have should be removed from setTaint and we should add an assert there so we
can catch the problem if it ever occurs again. Here is a patch for yecht:
{noformat}
--- a/ext/ruby/src/java/org/yecht/ruby/RubyLoadHandler.java
+++ b/ext/ruby/src/java/org/yecht/ruby/RubyLoadHandler.java
@@ -46,7 +46,7 @@ public class RubyLoadHandler implements NodeHandler {
// System.err.println(" -- LoadHandler, setting
id, yay!");
}
- if(bonus.taint) {
+ if(bonus.taint && !obj.isImmediate()) {
obj.setTaint(true);
}
{noformat}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
