Hi Vlad,

On Mon, Dec 7, 2009 at 12:39 PM, Vladimir Sizikov <[email protected]> wrote:
> Hi Yoko,
>
> On Mon, Dec 7, 2009 at 6:29 PM, Yoko Harada <[email protected]> wrote:
>> When I deleted "optional = 1" from the annotation of rationalize, I
>> didn't get java.lang.VerifyError. The embed test passed on JDK 1.5.
>> I wonder whether the annotation of rationalize method is correct or
>> not. If the method works without "optional = 1" in the @JRubyMethod,
>> may I delete this?
>
> I think that instead of removing optional=1 we should adjust the arguments 
> from
>
> IRubyObject arg
>
> to
>
> IRubyObject[] args

This worked! Thanks.

> Could you please check that this change fixes the problem?

Adjusting the arguments would be the answer. Are you going to push the fix?

-Yoko

>
> Thanks,
>  --Vladimir
>
>>
>> -Yoko
>>
>> On Fri, Dec 4, 2009 at 9:35 AM, Yoko Harada <[email protected]> wrote:
>>> Hi,
>>> Today, embed test fails on JDK 1.5 when ruby 1.9 mode is specified.
>>> The raised exception is:
>>>
>>> [junit] 致命的: Exception :
>>>    [junit] java.lang.VerifyError: (class:
>>> org/jruby/RubyComplex$i_method_0_1$RUBYINVOKER$rationalize, method:
>>> call signature:
>>> (Lorg/jruby/runtime/ThreadContext;Lorg/jruby/runtime/builtin/IRubyObject;Lorg/jruby/RubyModule;Ljava/lang/String;[Lorg/jruby/runtime/builtin/IRubyObject;)Lorg/jrub
>>>    [junit]     at
>>> org.jruby.gen.org$jruby$RubyComplex$Populator.populate(org$jruby$RubyComplex$Populator.java:131)
>>>    [junit]     at
>>> org.jruby.RubyModule.defineAnnotatedMethodsIndividually(RubyModule.java:657)
>>>    [junit]     at 
>>> org.jruby.RubyModule.defineAnnotatedMethods(RubyModule.java:560)
>>>    [junit]     at 
>>> org.jruby.RubyComplex.createComplexClass(RubyComplex.java:92)
>>>    [junit]     at org.jruby.Ruby.initCore(Ruby.java:1134)
>>>    [junit]     at org.jruby.Ruby.bootstrap(Ruby.java:1031)
>>>    [junit]     at org.jruby.Ruby.init(Ruby.java:1009)
>>>    [junit]     at org.jruby.Ruby.newInstance(Ruby.java:173)
>>>    [junit]     at
>>> org.jruby.embed.internal.LocalContext.getRuntime(LocalContext.java:97)
>>>    [junit]     at
>>> org.jruby.embed.internal.ThreadSafeLocalContextProvider.getRuntime(ThreadSafeLocalContextProvider.java:55)
>>>    [junit]     at
>>> org.jruby.embed.ScriptingContainer.getRuntime(ScriptingContainer.java:280)
>>>    [junit]     at 
>>> org.jruby.embed.bsf.JRubyEngine.initialize(JRubyEngine.java:157)
>>> .....
>>>
>>> The test succeeds on JDK 1.6.
>>> Does anybody have an idea on this?
>>>
>>> -Yoko
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe from this list, please visit:
>>
>>    http://xircles.codehaus.org/manage_email
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to