[FindBugs] Use Map of java.net.URIs, instead of java.net.URLs.
--------------------------------------------------------------
Key: JRUBY-4609
URL: http://jira.codehaus.org/browse/JRUBY-4609
Project: JRuby
Issue Type: Improvement
Components: Performance
Affects Versions: JRuby 1.4, JRuby 1.5
Environment: trunk, Mac OS X 10.6.2, Java 6
Reporter: Hiro Asari
Assignee: Charles Oliver Nutter
Attachments:
0001-FindBugs-Use-map-of-java.net.URIs-instead-of-java.ne.patch
FindBugs advises against the use of a map of URLs. It points to
http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html,
which explains why.
The attached file addresses the issue. The specs and tests pass, but without
concrete benchmarking results, I'm not sure if I'm doing the right thing (or,
if there is a problem at all). In addition, the patch swallows a
URISyntaxException in indexJarContents, which *could* be critical.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
