Clean up anything that calls dataGetStruct on a wrapped Java object to get the
object
-------------------------------------------------------------------------------------
Key: JRUBY-4732
URL: http://jira.codehaus.org/browse/JRUBY-4732
Project: JRuby
Issue Type: Bug
Components: Java Integration
Affects Versions: JRuby 1.5
Reporter: Charles Oliver Nutter
Assignee: Charles Oliver Nutter
Fix For: JRuby 1.5
In 1.5, we made a lot of progress toward eliminating the double-wrapping of
Java objects present in previous versions. This was accomplished by adding a
simple Object reference to JavaProxy and only lazily creating the JavaObject we
used with dataWrapStruct.
Unfortunately there's still a lot of cases that use dataGetStruct to get the
JavaObject to get the Object, which causes that wrapper to get stood up again.
I found a number of cases in JavaProxyMethods, for example, and there may be
others around.
In order to really solidify the memory and perf gains from having a simple
directly-wrapped Object, we should:
* Fix the cases in JavaProxyMethods
* Add some logging into the lazy code in JavaProxy that shows where it's being
called
* Fix those other cases
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
