Regexp caches don't invalidate if $KCODE changes
------------------------------------------------
Key: JRUBY-4889
URL: http://jira.codehaus.org/browse/JRUBY-4889
Project: JRuby
Issue Type: Bug
Components: Core Classes/Modules
Affects Versions: JRuby 1.5.1
Reporter: Nick Sieger
Assignee: Nick Sieger
Fix For: JRuby 1.6
$KCODE doesn't change often, but ActiveSupport::Multibyte tests change it
frequently. This causes issues with literal caching that doesn't take $KCODE
changes into account. Example failure:
{noformat}
$ jruby -Ilib:test test/multibyte_utils_test.rb -n
test_clean_cleans_invalid_characters_from_Shift-JIS_encoded_strings -n
test_clean_cleans_invalid_characters_from_UTF-8_encoded_strings -v
Loaded suite test/multibyte_utils_test
Started
test_clean_cleans_invalid_characters_from_Shift-JIS_encoded_strings(MultibyteUtilsTest):
.
test_clean_cleans_invalid_characters_from_UTF-8_encoded_strings(MultibyteUtilsTest):
F
Finished in 0.152 seconds.
1) Failure:
test_clean_cleans_invalid_characters_from_UTF-8_encoded_strings(MultibyteUtilsTest)
[test/multibyte_utils_test.rb:74:in
`test_clean_cleans_invalid_characters_from_UTF-8_encoded_strings'
./test/abstract_unit.rb:37:in `with_kcode'
test/multibyte_utils_test.rb:72:in
`test_clean_cleans_invalid_characters_from_UTF-8_encoded_strings'
/Users/nicksieger/Projects/ruby/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in
`run'
/Users/nicksieger/Projects/ruby/rails/activesupport/lib/active_support/callbacks.rb:419:in
`_run_setup_callbacks'
/Users/nicksieger/Projects/ruby/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:65:in
`run']:
<"こにちわ"> expected but was
<"">.
2 tests, 3 assertions, 1 failures, 0 errors
{noformat}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email