On Fri, Nov 18, 2011 at 7:11 AM, Hirotsugu Asari <asari.r...@gmail.com>wrote:
> On Nov 18, 2011, at 5:57 AM, Matt Wilbur wrote: > > I have a patch that I believe addresses a bug (6143, unassigned). How do > I try to get that into the main git repo? A pull request? I've already > posted my comments on jira and announced it here. > > It's a trivial thing but it would rock my world to make a jruby > contribution. > > Matt > > > Hi, Matt, > > It will be great to have your contribution! > > I might be in the minority, but I personally prefer a simple git-formatted > patch attached to JIRA. github pull requests would be nice if it were the > main repo, and that you didn't mind the resultant merges. (I think it is a > bit ugly.) > > To get the git formatted patch, you would commit to your local repository, > and issue 'git format-patch' with appropriate arguments. For example, if > you want to get the patches for the latest N commits, you'd say: git > format-patch -# (where # is the number of commits). > > I hope this helps. > > Hiro > Hi Hiro, I submitted an alternate patch to address JRUBY-6143. I thought the older patch was cleaner, but to address Thomas' concerns about string performance, I have placed the scan at the last possible moment to address this bug. I applied to to a branch forked right before the commit where you applied my other patch. Matt
