[ 
https://issues.apache.org/jira/browse/JSPWIKI-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Burch updated JSPWIKI-813:
--------------------------------

    Attachment: JSPWIKI-813-patch

This is my "minimum acceptable" patch, which resolves the two test failures, 
based on Juan Pablo's suggestions. It also includes many assertNotNull tests 
because findReferrers will return null to signal "none found".

I have another change which adds MANY comments to explain the tests (at least 
as far as I understand them!), and also tidys the entire source file so that it 
would pass the current tomcat code standards. I do not know whether this 
subsequent change would be welcome or not.

> ReferenceManagerTest - two cases fail
> -------------------------------------
>
>                 Key: JSPWIKI-813
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-813
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Unit Testing
>    Affects Versions: 2.10
>         Environment: linux low-latency kernel and openjdk quad-core processor 
> (tests run ok on dual-core generic kernel)
>            Reporter: Brian Burch
>            Priority: Minor
>              Labels: patch
>             Fix For: FutureVersion
>
>         Attachments: JSPWIKI-813-patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> testUpdateBothExist fails NPE, and testSelf fails InternalWikiException, both 
> in tearDown(). Seems to be a timing bug related to files created during other 
> tests not being cleared out properly.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to