Brian, if you'd like a larger role on the team, best to start submitting
patches on actual code functionality enhancements -- as you gain more
"cred" on the project, you'll naturally gain more influence on matters
such as code style, especially if you become a committer. I felt your
arguments were inadvertently weak because AFAICT you didn't specify
which standard you wished to follow (such as Sun/Java) but just what
*you* happened to think was a good coding style -- that's not a standard
though, as everyone has preferences.
FYI, what was perhaps missed from this topic was that we had already
agreed several months back that it's fine to use the Sun/Java standards
that you see on most Apache projects today in our code. (I've moved
maybe a few dozen classes over to the new standard while making other
changes to the code.) I don't recommend changing the code just for the
sake of changing formatting, but while making code functionality
improvements/fixes in particular classes, sure, then it would be fine to
update to the standard Sun/Java coding style as part of a patch.
Note, I also share your heavy dislike for the old-style formatting used
in the majority of the classes still today. That's not the issue here.
Regards,
Glen
On 02/20/2014 02:04 PM, Brian Burch wrote:
In my experience with tomcat, code style changes happen quite rarely,
and are debated in a mature and intelligent manner by everyone - not
just the committers. The project enforces its code style rules on
every build, but the committers are very polite to anyone submitting a
patch that does not conform. Based on my limited experience working on
jspwiki, that shouldn't be hard to emulate!
WDYT?
Brian
