[ 
https://issues.apache.org/jira/browse/JSPWIKI-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008895#comment-14008895
 ] 

Glen Mazza commented on JSPWIKI-842:
------------------------------------

Hi, Juergen, some concerns I have on this:

1.) Placing the jspwiki-custom.properties in the WEB-INF would confuse people, 
causing them to think it is meant to be placed there.  While it *could* work in 
that location (although why not directly alter the jspwiki.properties then?), 
it is intended to be placed in the servlet container classpath (Tomcat lib 
folder for example), so you can upgrade your JSPWiki WAR as often as you want 
without doing "war surgery" (opening up a new war archive and placing your 
configuration in it), instead, your specific configurations that you place in 
the jspwiki-custom.properties file will automatically carry over to your new 
WAR.

2.) Making the jspwiki-custom.properties identical to the jspwiki.properties 
will also further confuse people, thinking that it is necessary to duplicate 
default values from the latter to the former file, whereas in fact you only 
need to place in the jspwiki-custom.properties file those few properties that 
you wish to override in the latter.

You mention the "old jspwiki.properties", it's still there and an important 
part of JSPWiki configuration supplying default values -- it's just no longer 
meant to be edited directly (although, again, it can be).

However, one thing we definitely need to do is better document the current 
config process (a process which is basically identical to what Apache Roller 
has been doing for many years), when I get write access to 
https://jspwiki-wiki.apache.org/Wiki.jsp?page=Documentation I'll get it done.

> deliver a template for jspwiki-custom.properties
> ------------------------------------------------
>
>                 Key: JSPWIKI-842
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-842
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>    Affects Versions: 2.10
>            Reporter: Jürgen Weber
>
> In the delivered jspwiki.war there should be a 
> jspwiki-custom.properties.template in WEB-INF to get people started with a 
> jspwiki-custom.properties
> It should be well documented which would make it a copy of the old 
> jspwiki.properties ..
> I think starting from an existing properties file is easier than picking the 
> values from https://jspwiki-wiki.apache.org/Wiki.jsp?page=Configuration
> especially for people doing Advanced Installation.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to