[
https://issues.apache.org/jira/browse/JSPWIKI-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287355#comment-14287355
]
David Vittor commented on JSPWIKI-566:
--------------------------------------
Hi All,
Thanks for the feedback. Good to hear it's working for you Harry, so the idea
is right.
Dirk, I've gone though your list of items, and some of these are reasonably
simple to address, others however will require me to learn more javascript.
My response:
* Moved the ajaxJsonCall and ajaxHtmlCall into the Wiki namespace.
* Passing the params I don't fully understand how it works. I've added the
ability to pass an extra param that overrides the default maxResults value so
the functionality is maintained. I understand that some parameters may be
sensitive so we do not want to pass them through the URL, but for all the cases
in this project it currently seems ok (I think).
* I've parameterised the "/ajax/" prefix, so anything can be used. However this
is also in the *web.xml* and that cannot be arbitratily changed. Still in
future if we do want to change it it's in a lot less places.
* Request.JSON and Request.HTML - I'm not sure which library you mean. Is it
Prototype, or mootools. I've made this library independant, so that in future
when we move to jQuery, it might be easier. At least thats my thinking.
* The error handling is not done well, I agree. this will take more time, which
is currently limited.
* I think I only removed the stripScripts() from progress tracker, which
returns an integer. I think in that case it's safe.
* The last item was a typo. My daughter got to my keyboard.
The benefit is though that we get rid of that start up error. And I'm happy for
others to correct all the other "left overs" that are currently added in this
patch. I'll upload a new patch with todays changes.
Dirk, it's a good idea I will try and place this on my wiki for you to test.
Will see if I can get the time for this next week.
Let me know if you guys think, if I should check it in or not. The test cases
pass, but this is more UI / serlvets.
> AJAX server-side rewrite
> ------------------------
>
> Key: JSPWIKI-566
> URL: https://issues.apache.org/jira/browse/JSPWIKI-566
> Project: JSPWiki
> Issue Type: Improvement
> Components: Core & storage
> Affects Versions: 2.10.1
> Reporter: Janne Jalkanen
> Assignee: David Vittor
> Attachments: ajaxDispatchServlet.patch, ajaxFunctions.patch,
> ajaxFunctions.patch, test.html
>
>
> The AJAX library we're currently using is a bit problematic, as it stores
> non-serializable stuff in the HttpSession (causing all sorts of nasty
> exception reports in default configurations of Tomcat, and preventing
> clustering). It does provide a very nice, reflection-based interface so that
> we can expose any class/method as a JSON endpoint, but this does not really
> work well with our auth system.
> We should replace the jabsorb stuff with a Stripes-native solution (possibly
> with some extensions to allow particular beans to expose methods as if we
> were using jabsorb).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
