Hi Harry, that's weird I thought I got it running everywhere (at least cmd, cygwin and builds.a.o) :-?
In any case, my opinion would be to bring it in; I'd commit it directly to master, we're voting on a tag, and if the vote doesn't pass because of whatever, we'd like that for RC3 anyway. thx juan pablo On Sun, Feb 11, 2018 at 2:16 PM, Harry Metske <harry.met...@gmail.com> wrote: > The CommentedPropertiesTest fails (as stated earlier on the ML). > It fails both on Linux and MacOS. > It can be easily fixed by removing the carriage returns. (send the file > through tr -d '\r' ), then the tests succeed on both platforms. (I can't > test Windows). > Do you want me to commit these changes ? (on master ?) > > For the rest all OK, and my vote: +1 > > regards, > Harry > > > On 10 February 2018 at 01:37, Juan Pablo Santos Rodríguez < > juanpa...@apache.org> wrote: > > > Hi all, > > > > this is a release vote for Apache JSPWiki, version 2.10.3. The vote > > will be open for at least 72 hours from now. > > > > It fixes the following issues: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > projectId=12310732&version=12334934 > > > > Note that we are voting upon the source (tag), binaries are provided > > for convenience. > > > > Everybody is encouraged to vote. > > > > Source and binary files: > > https://dist.apache.org/repos/dist/dev/jspwiki/2.10.3-RC2 > > > > Nexus staging repo: > > https://repository.apache.org/content/repositories/orgapachejspwiki-1003 > > > > The tag to be voted upon: > > https://github.com/apache/jspwiki/tree/2.10.3-RC2 > > > > JSPWiki's KEYS file containing PGP keys we use to sign the release: > > https://www.apache.org/dist/jspwiki/KEYS > > > > *** Please download, test and vote: > > > > [ ] +1 Approve the release > > [ ] 0 Don't mind > > [ ] -1 Disapprove the release (please provide specific comments) > > > > > > br, > > juan pablo > > >
