[jira] [Closed] (JSPWIKI-641) IncludeResourcesTag doesn't work in 3.0

[JIRA]

     [ 
https://issues.apache.org/jira/browse/JSPWIKI-641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Juan Pablo Santos Rodríguez closed JSPWIKI-641.
-----------------------------------------------
       Resolution: Won't Fix
    Fix Version/s:     (was: 3.0)

refers to the Stripes build, which isn't developed anymore.

> IncludeResourcesTag doesn't work in 3.0
> ---------------------------------------
>
>                 Key: JSPWIKI-641
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-641
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Templates and UI
>    Affects Versions: 3.0
>         Environment: All
>            Reporter: Andrew Jaquith
>            Assignee: Andrew Jaquith
>            Priority: Minor
>
> This is a note to self to fix IncludeResourcesTag and RequestResourceTag so 
> that they work in 3.0. Current 3.0 trunk builds don't support adding 
> arbitrary resources because I removed JSPServletFilter.
> ----- note from jspwiki-dev thread ------
> While I continue to feel that it makes more sense to use the Stripes layout 
> tags, we could make the IncludeResources and RequestResource tags work if we 
> did the following:
> * When a RequestResource tag is encountered, stash the requested content into 
> the request as an attribute
> * When the IncludeResource tag is encountered, retrieve the attributes and 
> send to the output stream
> This could work nicely in 3.0 because of how we separate the layout JSPs from 
> the content JSPs. The content JSPs are processed before the layout JSPs, 
> which means RequestResources tags always execute before the IncludeResources 
> tags.
> So, this would be pretty simple to implement, and it would not require a 
> response wrapper. The code that requests and renders the resources would be 
> private (inside the tags), and thus restricted to JSP authors who used the 
> tags in their JSPs. That would satisfy my concerns about safety -- my chief 
> concern was the public access to the resource request API by plugins. Plugin 
> authors could always muck around with request attributes if they wanted to 
> inject their own resource requests, but it would be clear that they were "off 
> the reservation" at that point.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)