brushed commented on pull request #44:
URL: https://github.com/apache/jspwiki/pull/44#issuecomment-791912513
Looking at the proposed patch, I'm not in favor of taking this into the
code base.
How does the current JSPWiki Cookie notification work :
In the LeftMenu page, you will find something like:
{{{
[{InsertPage page='Cookie Policy' show='once' section='1' }]
}}}
Actually, the "Cookie Policy" page could point to any page
the user or site administrator wants to use for putting the cookie policy
description of its wiki.
What the InsertPage plugin does is, it will display the first section of
that page.
but only during the first visit of that page. After that, it will remember
that
this content has already been shown (via a cookie) and not display it again.
By default the 'show-once' content is presented in a modal dialog box; but
the
user can specify other styles. (eg in page information box)
For more details on the InsertPagePlugin see its documentation page.
This means that JSPWiki is not implementing any specific code to show this
dialog box. All is driven by the content of your wiki.
EG: The admin of the site can fully determine what happens
when a user is presented with the Cookie Policy pop-up.
What happens when selecting the CANCEL button, etc.
EG, if you would be using this wiki on an intranet, you may not need a
strong
cookie policy. You would simply not include it in your LeftMenu page, and
never get any pop-up.
EG, if the admin would be including a Google AD tracker, all he needs to do
is update its Cookie Policy page. No changes or rebuild of JSPWiki is
needed,
no changes are needed on the I18N properties of JSPWiki etc ..
* * *
JSPWiki always uses Cookies, a user cannot turn it 100% off.
2 Cookies are always present: one to keep track of your SESSION (needed for
editing),
and one to store the user's preferences.
The initial user preference cookie values are determined by the admin
setting of your site,
and are changed whenever the user modifies them.
This means that a user can never "opt-out".
A user has to accept ("ok understood" button) or click the ('learn more")
button.
Other cookies managed by JSPWiki (eg created by other InsertPage plugins
with a show='once')
can be viewed or deleted on the User Preferences page.
Grtz,
dirk
On Tue, Mar 2, 2021 at 9:54 PM takalat <[email protected]> wrote:
> *@takalat* commented on this pull request.
> ------------------------------
>
> In jspwiki-main/src/main/java/org/apache/wiki/preferences/Preferences.java
> <https://github.com/apache/jspwiki/pull/44#discussion_r585901825>:
>
> > @@ -125,19 +133,21 @@ public static void reloadPreferences( final
PageContext pageContext ) {
> * @param request
> * @param prefs The default hashmap of preferences
> */
> - private static void parseJSONPreferences( final HttpServletRequest
request, final Preferences prefs ) {
> - final String prefVal = TextUtil.urlDecodeUTF8(
HttpUtil.retrieveCookieValue( request, "JSPWikiUserPrefs" ) );
> - if( prefVal != null ) {
> + private static void parseJSONPreferences( final Preferences prefs,
final String prefVal ) {
>
> I assume this meant only changing signature to package scope. Changed
> method modifier to in the latest commit.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/jspwiki/pull/44#discussion_r585901825>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AA5QPBYBKL6OXTR6TQ44DVTTBVGA5ANCNFSM4YLBIHKA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
