juanpablo-santos commented on code in PR #242:
URL: https://github.com/apache/jspwiki/pull/242#discussion_r1162005963
##########
pom.xml:
##########
@@ -472,6 +474,21 @@
</execution>
</executions>
</plugin>
+
+ <plugin>
Review Comment:
I'd rather not include it, mainly because of two reasons
* You can still `mvn pmd:check` or `mvn pmd:pmd` and get the same result
* Having a quick look at the report, it suggests a lot of changes that (for
me) make the code harder to read without any real benefit (collapsible ifs,
superfluous parenthesis), so I'm not very comfortable blindly following the
report
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
