juanpablo-santos commented on code in PR #213:
URL: https://github.com/apache/jspwiki/pull/213#discussion_r1162012699
##########
jspwiki-event/pom.xml:
##########
@@ -45,6 +45,12 @@
<artifactId>commons-lang3</artifactId>
</dependency>
+ <dependency>
Review Comment:
I'd rather not use a constant for blank spaces, slashes or other types of
constants where there is no semantic meaning into them. Using these kind of
constants only couples two modules b/c of a constant (or brings in
commons-lang) for the sake of reusing a constant.
In this case, jspwiki-event will bring jspwiki-utils and all of its
transitive dependencies, just for a constant, that is going to be translated to
its value by the compiler on compile time. It'd be different if the constant
would be referring to, i.e., a specific key of the jspwiki.properties file,
then it would make sense to me
WDYT? (and what do others think about this?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
