Hi Ulf! thanks for spotting that, I've fixed it just now
cheers, juan pablo On Fri, Jul 25, 2025 at 2:27 PM Ulf Dittmer <ulf.ditt...@googlemail.com.invalid> wrote: > > There's a tiny cops/paste error in > https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn2.12: I had nothing to > do with JSPWIKI-1197, that was someone called "spyhunter99". > > Otherwise, I'm happy to see this go out! > > Ulf > > On Fri, Jul 25, 2025 at 1:58 PM Juan Pablo Santos Rodríguez < > juanpablo.san...@gmail.com> wrote: > > > Ugh I've to cancel the vote due to log4j2 parsing of properties files > > causing application not being able to start up if it contains custom > > jspwiki properties that do not start with "jspwiki". This happens with > > vanilla JSPWiki which sets up a few mail.* properties. This can be > > workarounded by setting up a custom log4j2 configuration file, but > > having to force anyone using JSPWiki to do this or use a custom > > jspwiki file is enough to cancel the release > > > > > > https://github.com/apache/jspwiki/commit/611768828eb0f6fbb149189fc12482be01c36be8 > > restricted the properties passed to Log4J to those not starting with > > jspwiki, so log4j 2.25.1 is able to be set up. > > > > Unfortunately, that means that any other non log4j property present in > > the configuration file is fed to Log4J, causing errors on startup > > like: > > org.apache.logging.log4j.core.config.ConfigurationException: No type > > attribute provided for component mail > > at > > org.apache.logging.log4j.core.config.properties.PropertiesConfigurationBuilder.createComponent(PropertiesConfigurationBuilder.java:362) > > at > > org.apache.logging.log4j.core.config.properties.PropertiesConfigurationBuilder.processRemainingProperties(PropertiesConfigurationBuilder.java:206) > > at > > org.apache.logging.log4j.core.config.properties.PropertiesConfigurationBuilder.build(PropertiesConfigurationBuilder.java:190) > > at > > org.apache.logging.log4j.core.config.properties.PropertiesConfigurationFactory.getConfiguration(PropertiesConfigurationFactory.java:56) > > at > > org.apache.wiki.bootstrap.WikiBootstrapServletContextListener.initWikiLoggingFramework(WikiBootstrapServletContextListener.java:75) > > > > So instead of current approach, I'll make a new commit so that only > > proper log4j2 properties are passed to log4j configutation builder, > > which are, from what I've been able to see, properties starting with > > one of: appender, logger, rootLogger, filter, status, dest, name, > > properties, property, log4j2. If there are additional properties > > needed to be passed to log4j2, an external log4j2 config file can be > > set up, so I'd say that this fix should be enough to proceed with > > 2.12.3 > > > > darn > > > > I'll push the fix and restart the vote within the hour if possible > > > > > > best regards, > > juan pablo > > > > On Fri, Jul 25, 2025 at 1:27 PM Harry Metske <harry.met...@gmail.com> > > wrote: > > > > > > sha512sum OK > > > compile OK > > > installed on personal wiki OK > > > basic testing OK > > > > > > +1 vote from me > > > > > > Thanks for all the effort JP! > > > > > > regards, > > > Harry > > > > > > On Fri, 25 Jul 2025 at 13:07, Juan Pablo Santos Rodríguez < > > > juanpa...@apache.org> wrote: > > > > > > > This is a release vote for Apache JSPWiki, version 2.12.3. The vote > > > > will be open for at least 72 hours from now. > > > > > > > > You can see a curated changelog at > > > > https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn2.12 > > > > > > > > Note that we are voting upon the source (tag), binaries are provided > > > > for convenience. > > > > > > > > Everybody is encouraged to vote. > > > > > > > > Source and binary files: > > > > https://dist.apache.org/repos/dist/dev/jspwiki/2.12.3-RC1 > > > > > > > > Nexus staging repo: > > > > > > https://repository.apache.org/content/repositories/orgapachejspwiki-1033 > > > > > > > > The tag to be voted upon: > > > > https://github.com/apache/jspwiki/tree/2.12.3-RC1 > > > > > > > > JSPWiki's KEYS file containing PGP keys we use to sign the release: > > > > https://www.apache.org/dist/jspwiki/KEYS > > > > > > > > == Reproducible Builds == > > > > JSPWiki should follow Reproducible Builds > > > > (https://reproducible-builds.org/). In order to verify > > > > artifacts' build reproducibility, please use > > > > > > > > mvn verify artifact:compare > > > > -Dreference.repo= > > > > https://repository.apache.org/content/repositories/staging/ > > > > > > > > *** Please download, test and vote: > > > > > > > > [ ] +1 Approve the release > > > > [ ] 0 Don't mind > > > > [ ] -1 Disapprove the release (please provide specific comments) > > > > > >
