juanpablo-santos commented on code in PR #415:
URL: https://github.com/apache/jspwiki/pull/415#discussion_r2531885797
##########
jspwiki-api/src/main/java/org/apache/wiki/api/plugin/Plugin.java:
##########
@@ -48,5 +49,33 @@ public interface Plugin {
* @throws PluginException In case anything goes wrong.
*/
String execute( Context context, Map< String, String > params ) throws
PluginException;
+
+ /**
+ * Provides the ability for a plugin to provide a suggestion or template
+ * for execution within a wiki page. Default returns just the FQCN of the
+ * plugin, which should enable it to fire off, however no parameters are
+ * plugin.
+ *
+ * Example: com.company.Plugin inputParamter='test'
Review Comment:
small typo
##########
jspwiki-main/src/test/java/org/apache/wiki/ui/admin/beans/PluginBeanTest.java:
##########
@@ -40,17 +40,8 @@ public void testDoGet() throws WikiException,
NotCompliantMBeanException {
testEngine = new TestEngine( props );
final Context context = Wiki.context().create( testEngine,
Wiki.contents().page( testEngine, "TestPage01" ) );
final PluginBean pb = new PluginBean( testEngine );
- final String expectedHtml = "<div>" +
- "<h4>Plugins</h4>" +
- "<table border=\"1\">" +
-
"<tr><th>Name</th><th>Alias</th><th>Author</th><th>Notes</th></tr>" +
-
"<tr><td>IfPlugin</td><td>If</td><td>Janne Jalkanen</td><td></td></tr>" +
- "<tr><td>Note</td><td></td><td>Janne
Jalkanen</td><td></td></tr>" +
-
"<tr><td>SamplePlugin</td><td>samplealias</td><td>Janne
Jalkanen</td><td></td></tr>" +
-
"<tr><td>SamplePlugin2</td><td>samplealias2</td><td>Janne
Jalkanen</td><td></td></tr>" +
- "</table>" +
- "</div>";
- Assertions.assertEquals( expectedHtml, pb.doGet( context ) );
+
+ Assertions.assertNotNull( pb.doGet( context ) );
Review Comment:
curious on why the change no the assertion :-?
##########
jspwiki-portable/build.xml:
##########
@@ -69,12 +69,19 @@
<!-- copy the exploded war for the "personal" wiki -->
<copy todir="${jspwiki.woas.assembly.dir}/webapps/personal"
overwrite="true">
<fileset dir="${jspwiki.woas.unpack.dir}/jspwiki-war/"/>
+ </copy>
+ <!-- copy our test hello world plugin for verifying plugin
discoverability -->
+ <copy todir="${jspwiki.woas.assembly.dir}/jspwiki/lib" overwrite="true">
Review Comment:
is it really needed here?
##########
jspwiki-main/src/main/java/org/apache/wiki/plugin/Counter.java:
##########
@@ -38,7 +38,9 @@ Licensed to the Apache Software Foundation (ASF) under one
* </ul>
*
* @since 1.9.30
+ * @deprecated use PageViewCounter
*/
+@Deprecated
Review Comment:
why? this sets a counter, which is reset on every page render,
PageViewCounter stores page views, which seems different to me, IIUI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
