[ 
https://issues.apache.org/jira/browse/JSPWIKI-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18040416#comment-18040416
 ] 

Dirk Frederickx commented on JSPWIKI-1102:
------------------------------------------

Alex,
Congrat's you got it working! 

Some remarks with the propsed implementation:

-Since %%chartist would be a new behaviour that you add to JSPWiki,  I'd 
suggest  you add it to the Wiki.Behaviours.js  file,  which contains all 
behaviours.  It probably also simplifies things, as you don't need the 
charity() helper call.

-You have added additional CSS and JS links to the commonheader.jsp.   This 
means that for every wiki page, these external files will be loaded (and may 
slow down the page reder time), even when never used!   
I'd suggest you'd keep the initial javascript code which dynamically add's the 
external css and js links in case a page invokes the %%chartist behaviour.

-there are now hardcoded references to a specific version of the chartist 
library. (currently the latest)  Probably it would be better to have those 
links configurable,  and not hardcoded.


BR,
      dirk


BTW, a similar and very useful extension to JspWiki may be the Math Behaviour ! 
 See [https://jspwiki-wiki.apache.org/Wiki.jsp?page=Math%20Behavior.]

> Add charting library to JSPWiki distribution
> --------------------------------------------
>
>                 Key: JSPWIKI-1102
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-1102
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Templates and UI
>            Reporter: Dirk Frederickx
>            Assignee: Alex O'Ree
>            Priority: Minor
>         Attachments: image-2025-11-23-14-07-13-571.png
>
>
> Add a charting library to JSPWiki for easy rendering data in TABLE's as line, 
> pie- or bar-charts.
>  The charting library should provide well chosen defaults to keep the extra 
> markup as little as possible.
> Proposal:
>  Include [https://gionkunz.github.io/chartist-js/]  (MIT license) in the 
> standard JSPWiki's distribution.
>  * small footprint  (10K zipped JS; only loaded in pages with require charts)
>  * usage of svg; high quality device independent
>  * highly customizable;  but using 'convention over configuration'  (great 
> defaults)
>  * responsive  (great output on mobile devices)
>  
> Prereq: https://issues.apache.org/jira/browse/JSPWIKI-1040
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to