Hi,

unless I'm doing something wrong, it would be a -1 for me.

Overall code looks good, build fine and everything seems in place.
However, after compiling everything, running mvn
org.codehaus.cargo:cargo-maven3-plugin:run on the war module and
waiting tomcat to start, going to http://localhost:8080/JSPWiki
automatically redirects to https://localhost:8443/JSPWiki. If this
only happens using the maven plugin, I'd be ok to +1 and fix this
later, but downloading a vanilla tomcat and placing the war on it
yields the same results.

Also, as a minor nitpick, the provided tag URL is wrong, the tag
appears to be https://github.com/apache/jspwiki/tree/jspwiki-builder-3.0.0-RC1
(probably it's the name of the tag offered by default by the release
plugin). This is easily fixable as this tag can be retagged to
3.0.0-RC1, though.


cheers,
juan pablo

On Sat, Mar 21, 2026 at 6:34 PM Alex O'Ree <[email protected]> wrote:
>
> This is a release vote for Apache JSPWiki, version 3.0.0. The vote will be
> open for at least 72 hours from now.
>
> It fixes the following issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310732&version=3.0.0
>
> You can see a curated changelog at
> https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn3.0.0
> Although according to the release procedure, this is updated after the
> release is voted on and approved.
>
> Note that we are voting upon the source (tag), binaries are provided for
> convenience.
>
> Everybody is encouraged to vote.
>
> Source and binary files:
> https://dist.apache.org/repos/dist/dev/jspwiki/3.0.0-RC1
>
> Nexus staging repo:
> https://repository.apache.org/content/repositories/orgapachejspwiki-1035
>
> The tag to be voted upon:
> https://github.com/apache/jspwiki/tree/3.0.0-RC1
>
> JSPWiki's KEYS file containing PGP keys we use to sign the release:
> https://www.apache.org/dist/jspwiki/KEYS
>
> == Reproducible Builds ==
> JSPWiki should follow Reproducible Builds (https://reproducible-builds.org/).
> In order to verify
> artifacts' build reproducibility, please use
>
> mvn verify artifact:compare -Dreference.repo=
> https://repository.apache.org/content/repositories/staging/
>
> *** Please download, test and vote:
>
> [ ] +1 Approve the release
> [ ]  0 Don't mind
> [ ] -1 Disapprove the release (please provide specific comments)

Reply via email to