juanpablo-santos commented on code in PR #525:
URL: https://github.com/apache/jspwiki/pull/525#discussion_r4045745794
##########
jspwiki-main/src/main/java/org/apache/wiki/WikiSession.java:
##########
@@ -150,6 +150,14 @@ public String antiCsrfToken() {
return antiCsrfToken;
}
+ /**
+ * Regenerates the anti-CSRF token. Called when the session's privilege
level changes (i.e. at login), so that
+ * a token observed before authentication cannot be replayed against the
authenticated session.
+ */
+ public void regenerateAntiCsrfToken() {
Review Comment:
perhaps this should be a default empty method as well on the `Session`
interface? That would allow to omit the downcasting at
`DefaultAuthenticationManager#rotateSessionAfterAuthentication` above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
