arturobernalg commented on PR #232: URL: https://github.com/apache/jspwiki/pull/232#issuecomment-6340879763
Hi @juanpablo-santos, @spyhunter99, sorry for the long delay. The requested changes are done: I rebased this PR on the current master and reworked it, so it is ready for another look. The encoding used for the output of the external command is now the wiki one (engine.getContentEncoding()), as suggested, and it is applied throughout the call. While doing this I found that ExternalDiffProvider kept re-encoding the output as ISO-8859-1 and decoding it again, which turned characters outside Latin-1 (for example the euro sign) into "?". The output is now decoded once, with the encoding the temporary files are written with. ExternalDiffProviderTest fails on master and passes with this change. On the Base64 String in Serializer: Base64 output is always ASCII, which is the same byte sequence in UTF-8, so the choice does not restrict internationalization; the attribute values are inside the serialized bytes before they are Base64 encoded. The method keeps its signature, so no public API changes. FileUtil#runSimpleCommand keeps its two argument variant and gains one that takes the charset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
