arturobernalg commented on PR #234: URL: https://github.com/apache/jspwiki/pull/234#issuecomment-6341248409
Hi @juanpablo-santos, sorry for the long delay. I rebased this PR on the current master and rechecked every access to the lists, as you asked. You were right about the iteration. Lists traversed concurrently with changes (the entries and permissions of an ACL, the members of a Group, the temporary ban list of SpamFilter) are now CopyOnWriteArrayList, so no manual synchronization is needed when iterating them. The remaining ones are only accessed under a lock of their owner (the preload cache of WikiEventManager under m_delegates, whose clear now happens in the same block, and the modifications list of SpamFilter under the filter's monitor), so they are plain ArrayLists. I also dropped the XML-RPC handlers and PingWeblogsComFilter from this PR, as the XML-RPC library requires Vector in its signatures. Please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
