The GitHub Actions job "Java CI" on jspwiki.git/feature/JSPWIKI-1254 has failed.
Run started by GitHub user arturobernalg (triggered by arturobernalg).

Head commit for run:
b1022c0d53bea778f671f24d58670e249adf5513 / Arturo Bernal <[email protected]>
JSPWIKI-1254 Make the lock of a user profile work

A user profile can be locked until a date, but nothing made use of it:

- UserDatabaseLoginModule never looked at the lock, so a locked profile could
  log in. It now refuses a locked profile that supplies the right password with 
an
  AccountLockedException. With a wrong password the failure is the usual one, so
  the lock is not disclosed to someone who does not know the password.
- XMLUserDatabase wrote the lock expiry in its date format but read it with
  Long.parseLong, so a saved lock made the profile unreadable with a
  NumberFormatException. It now reads the date format, still accepts 
milliseconds,
  and keeps the profile locked if the value cannot be read.
- JDBCUserDatabase stored the lock expiry as a date, without the time, so a lock
  of an hour ended at midnight of the day it was set and the profile was not 
locked
  when read back. It now stores a timestamp.

This is needed before locking accounts automatically.

Report URL: https://github.com/apache/jspwiki/actions/runs/40881163378

With regards,
GitHub Actions via GitBox

Reply via email to