[ 
https://issues.apache.org/jira/browse/JSPWIKI-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134358#comment-18134358
 ] 

Arturo Bernal commented on JSPWIKI-613:
---------------------------------------

Reproduced with the current code (master plus an unrelated parser change, 
Tomcat 10.1, Chrome, plain editor, section editing on). I made a page 
HostInsert with two headings and a line with the InsertPage plugin for another 
page that has three headings. In the view of HostInsert, the edit links of the 
three headings of the inserted page edit the page HostInsert, with the section 
numbers 2, 3 and 4 that count the headings of the whole rendered page, while 
the text of HostInsert has only the two headings 0 and 1. Opening the link of 
the first inserted heading (section 2) gave the editor of HostInsert with the 
whole text of HostInsert, not a section of the inserted page.

So the report holds today. The anchors of the headings already carry the name 
of the page they come from: the headings of HostInsert have anchors starting 
with section-HostInsert and those of the inserted page start with 
section-EditPageHelp, which is the information that the 2009 comments say would 
be needed; the problem of names that contain a dash, mentioned there, is still 
open. Disabling the edit links of inserted content, or pointing them to the 
inserted page with its own count, are the two options discussed and both need a 
decision.

Limits: I tried the InsertPage plugin alone, not inside a tabbed section, and 
only Chrome. Leaving the issue open.

> InsertPage plugin and the feature of section editing do not fit together
> ------------------------------------------------------------------------
>
>                 Key: JSPWIKI-613
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-613
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.8.3
>         Environment: Current versions of Windows XP and Firefox running in a 
> virtual machine of VMWare Fusion on a Mac Server
>            Reporter: Mario Lotz
>            Priority: Minor
>
> I often used the *InsertPage plugin* to separate structure  of my 
> presentation from the content. Normaly I include pages into tabbed sections 
> to give my users a single point of entry to the same kind of information.
> If the *section editing feature* is enabled the rendered *edit links* are 
> pointing to the {color:red}_including_{color} page instead of the 
> {color:red}_included_{color} ones.
> I assume, that the links are added to the page after the includes are done. 
> To fix the wrong links, the edit links have to be inserted for each included 
> page independent of the parent and with a separate heading counter.
> This is my first bug report for your great JSPWiki and I hope to give you 
> enough information.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to