arturobernalg opened a new pull request, #567: URL: https://github.com/apache/jspwiki/pull/567
The only code of the main module that used xmlrpc-2.0.1 was PingWeblogsComFilter, which sends the weblogUpdates.ping call after a weblog entry is saved. The jspwiki-xmlrpc module has no pom and is not part of the build, and the server side of XML-RPC is gone from master. The filter now builds the call itself and sends it with the HTTP client of the JDK (asynchronously, with a timeout, content type text/xml). The answer is read with a parser that does not accept a DTD. The dependency is removed from both poms and from LICENSE, so the old library, which brought XML parser classes that clash with the ones of the JDK, is no longer part of the war. Measured: - PingWeblogsComFilterTest (new, 3 tests) runs the filter against a local HTTP server: the ping of a weblog entry arrives with the right method and URL, a page that is not a weblog entry sends nothing, and the values of the call are escaped. 3 of 3 pass. - The whole project builds with package -DskipTests, and JSPWiki.war contains no xmlrpc entry. Not measured: the full jspwiki-main suite was not run, and the ping was not sent to rpc.weblogs.com, only to the local server. The issue asks to upgrade the library; this removes it instead, since it had one use. Updating to XML-RPC 3.1 would need three jars for that single call. ChangeLog.md and the BUILD of Release.java are updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
