arturobernalg opened a new pull request, #569: URL: https://github.com/apache/jspwiki/pull/569
JSPWIKI-1263: https://issues.apache.org/jira/browse/JSPWIKI-1263 DefaultGroupManager.removeGroup() now refuses to remove the group named Admin and throws a WikiSecurityException. The default security policy grants AllPermission to that group, so removing it could leave the wiki without administrators. GroupManager.removeGroup() documents the new exception. ChangeLog.md and the BUILD in Release.java are updated. Test: GroupManagerTest.testAdminGroupCannotBeRemoved. With the check disabled it fails (the expected exception is not thrown); with the change it passes. The full test suite of jspwiki-main passes (935 tests). Limits: only the removal of the group is blocked. Editing the group so that it has no members is not covered. DeleteGroup.jsp was not tried in a running wiki; it shows its generic "operation failed" message when removeGroup throws. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
