Arturo Bernal created JSPWIKI-1320:
--------------------------------------

             Summary: The RSS feed of a page diffs against a version that does 
not exist when a version was deleted
                 Key: JSPWIKI-1320
                 URL: https://issues.apache.org/jira/browse/JSPWIKI-1320
             Project: JSPWiki
          Issue Type: Bug
            Reporter: Arturo Bernal


The RSS feed of a page describes a change with a diff between the version and 
the one before it. DefaultRSSGenerator.getPageDescription takes the previous 
version as version - 1, as its FIXME says ("Will fail when non-contiguous 
versions").

Measured on the current master with VersioningFileProvider and the 
SvnStyleDiffProvider: I saved a page three times ("line one", then two lines, 
then three lines), deleted version 2 with PageManager.deleteVersion, and 
generated the RSS of the page for version 3. The description of the entry shows 
all three lines as added, although version 3 differs from the remaining version 
1 only by the lines "line two" and "line three". Reading version 2 fails with a 
ProviderException, which is logged at ERROR level twice, and the text of the 
missing version is taken as empty.

Expected: the diff is made against the latest version that still exists before 
the one described.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to