arturobernalg commented on code in PR #543: URL: https://github.com/apache/jspwiki/pull/543#discussion_r4445902428
########## jspwiki-main/src/main/java/org/apache/wiki/search/LuceneSearchProvider.java: ########## Review Comment: Thanks for trying it. Two of your searches, `name:blog*26_*` and `name:blog*26_1`, found pages on master and found nothing with this change. That was a defect of the change, and it is fixed in the new commit 7dc8f52bf, with a test for both. I measured them with a page named `Blog_blogentry_021126_1` and two similar ones: on master `name:blog*26_1` finds two of them and `name:blog*26_*` finds all three. `name:blog*26` and `name:entry*26*` find nothing on master either, with or without this change: a wildcard is applied inside a single indexed token. I did not read the indexer closely enough to say how the page name is split into tokens, so I do not claim more than that. The relevance values above 100 also come from the existing code, which multiplies the score by 100 without a maximum. This pull request does not change that, and I measured values such as 108 and 255 on the branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
