arturobernalg opened a new pull request, #578: URL: https://github.com/apache/jspwiki/pull/578
JSPWIKI-1324: the time zone and time format lists of the user preferences page are wider than a narrow screen. One of the points of JSPWIKI-1099 (responsive design of that page). The rule `.form-group select` in `forms.less` did not limit the width, so each list is as wide as its longest option. It has `max-width: 100%` now. Measured with the WAR on Tomcat 10.1, loading `UserPreferences.jsp` in Chromium and taking the right edge of every element that is not `position: fixed`: | Width of the screen | Elements past the right edge on master | On this branch | |---|---|---| | 360 px | 2 (the time format list ends at 385 px, the time zone list at 594 px) | 0 | | 500 px | 1 (the time zone list ends at 594 px) | 0 | | 800 px | 0 | 0 | | 1327 px | 0 | 0 | The page does not scroll sideways on master either (its scroll width is the width of the screen). Not tested: Firefox, Edge and Safari, other pages with a select list in a form, how the lists look at those widths (only the position of their edges was measured), and no automated test covers a stylesheet. https://issues.apache.org/jira/browse/JSPWIKI-1324 (related to JSPWIKI-1099) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
