arturobernalg commented on PR #575: URL: https://github.com/apache/jspwiki/pull/575#issuecomment-6631158747
Thanks, that is a fair point. I measured a few searches with the code of #543 (what master has now) and with this pull request, on 11 pages: UnserBlog, four UnserBlog_blogentry pages, three Weblog_blogentry pages, Man_Page, Human_Page and Woman_Page. On master, name:blog*26 finds 0 pages but name:blog*26* finds 3, and name:man*pa* finds 0 although name:man* finds Man_Page. With this pull request name:entry*26 finds 3 pages, name:man*pa* finds Man_Page, Human_Page and Woman_Page, and name:blog*1 finds 6 pages instead of 5. name:entry and name:entry* find nothing in both. If matches should only start at the beginning of a word, I would drop the part of this pull request that looks inside the words, so that name:entry*26 finds nothing, and make a * at the end optional, so that name:blog*26 and name:blog*26* both find UnserBlog_blogentry_261023_1, Weblog_blogentry_021126_1 and Weblog_blogentry_031226_1. Is that what you would expect, or should name:blog*26 find nothing? About the bars, I will do that in a separate ticket, so that the bar is strictly proportional to the value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
