[ 
https://issues.apache.org/jira/browse/JSPWIKI-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139090#comment-18139090
 ] 

Arturo Bernal commented on JSPWIKI-1354:
----------------------------------------

Pull request: https://github.com/apache/jspwiki/pull/585

The test waits until the three pages are found before it compares the results. 
The same pattern was in two tests of pull request 575, which are changed there 
too.

> SearchManagerTest.testWildcardKeepsMatchesOfTokensHoldingUnderscores fails 
> when the index is not ready
> ------------------------------------------------------------------------------------------------------
>
>                 Key: JSPWIKI-1354
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-1354
>             Project: JSPWiki
>          Issue Type: Bug
>            Reporter: Arturo Bernal
>            Priority: Major
>              Labels: pull-request-available
>
> SearchManagerTest.testWildcardKeepsMatchesOfTokensHoldingUnderscores (added 
> with JSPWIKI-501, pull request 543) failed in the check Java CI / build 
> (windows-latest, 17) of pull request 565 with: expected: 
> <[Blog_blogentry_021126_1, Blog_blogentry_031226_1]> but was: 
> <[Blog_blogentry_031226_1]> (SearchManagerTest.java line 268).
> The test saves three pages and then waits until the search for name:blog 
> finds a result, which happens as soon as the first page is indexed. The index 
> is built in the background, so the other pages may not be there yet when the 
> result is compared with all three. The cause comes from reading the test and 
> the failure; I have not reproduced it locally.
> The test should wait until the three pages are found before it compares the 
> results. I checked that SearchManagerTest passes (13 tests) with that change.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to