[
https://issues.apache.org/jira/browse/JSPWIKI-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139920#comment-18139920
]
ASF subversion and git services commented on JSPWIKI-1320:
----------------------------------------------------------
Commit a05f75339dcdad5d93caf29236ee84cde6ee2227 in jspwiki's branch
refs/heads/master from Arturo Bernal
[ https://gitbox.apache.org/repos/asf?p=jspwiki.git;h=a05f75339 ]
JSPWIKI-1320 Diff a version of a page with the one before it in its RSS feed
The description of an entry in the RSS feed of a page took the version before
the one
described as version - 1. When that version had been deleted, reading it failed
with a
ProviderException, which was logged twice, and its text was taken as empty, so
the entry showed
the whole page as added.
The entry is now diffed against the latest version that still exists before the
one described. A
page without an earlier version is described as created, as before.
> The RSS feed of a page diffs against a version that does not exist when a
> version was deleted
> ---------------------------------------------------------------------------------------------
>
> Key: JSPWIKI-1320
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1320
> Project: JSPWiki
> Issue Type: Bug
> Reporter: Arturo Bernal
> Priority: Major
> Labels: pull-request-available
>
> The RSS feed of a page describes a change with a diff between the version and
> the one before it. DefaultRSSGenerator.getPageDescription takes the previous
> version as version - 1, as its FIXME says ("Will fail when non-contiguous
> versions").
> Measured on the current master with VersioningFileProvider and the
> SvnStyleDiffProvider: I saved a page three times ("line one", then two lines,
> then three lines), deleted version 2 with PageManager.deleteVersion, and
> generated the RSS of the page for version 3. The description of the entry
> shows all three lines as added, although version 3 differs from the remaining
> version 1 only by the lines "line two" and "line three". Reading version 2
> fails with a ProviderException, which is logged at ERROR level twice, and the
> text of the missing version is taken as empty.
> Expected: the diff is made against the latest version that still exists
> before the one described.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
