arturobernalg commented on PR #576: URL: https://github.com/apache/jspwiki/pull/576#issuecomment-6710460068
@spyhunter99, thank you for testing it in Firefox. I could reproduce what you describe with Firefox 159, headless, on a reload with cached files. What jumps is the tabs of the login page: until the script has built the tabs, the three sections (Login, Lost password, Register New User) are in view as plain text, and about half a second later the script hides all but one and the page shrinks from 1549 to 443 px. It is the same on master and on this branch, so the header change did not cause it. On a normal page, master moves the content from y=0 to y=106 and the footer from y=160 to y=750 at about 550 ms, and this branch has both in place from the first frame. I pushed a commit (606b8e593) that hides the container of the tabs with CSS until the script has built them, only when scripting is enabled. On the login page the first frame no longer shows the sections, the footer is at y=750 from the start and does not move, and the tabs appear after about 560 ms. I also checked with JavaScript disabled: the three sections and the login form are still shown. Not tested: Chromium, Edge and Safari with this commit, and the other pages that use tabs (info, preferences, workflow, admin). The CSS uses :has and the scripting media query, so older browsers keep the old behaviour. I also merged master to resolve a conflict in ChangeLog.md. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
