arturobernalg opened a new pull request, #591: URL: https://github.com/apache/jspwiki/pull/591
Backport of https://github.com/apache/jspwiki/pull/568 to master-2.x, as Juan Pablo asked there. PropertyReader built the keys of the jspwiki.* system properties with Object::toString of each entry, which gives key=value, so it never found a system property under its own key. It uses stringPropertyNames and System::getProperty now. The patch of master did not apply as it is, because the imports of PropertyReader differ in this branch; the change is the same. Checked locally: PropertyReaderTest fails on master-2.x with the new test alone (expected fromSystem but was null) and passes with the change; the whole build of master-2.x with the change passes, 1153 tests and no failures; and on a running war (Tomcat 9) started with -Djspwiki.preferences.default-locale=de, the login page of master-2.x without the change stays in English, and with the change it is in German. Not tested: the integration tests. ChangeLog.md has a new block, 2.12.6-git-02, and BUILD of Release.java is 02, since this opens a block. Please tell me if you prefer it another way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
