juanpablo-santos commented on PR #589: URL: https://github.com/apache/jspwiki/pull/589#issuecomment-6817062330
Hi! Some comments, regardless when this comes in - separate module: wouldn't these classes fit better on a separate maven module? jspwiki-rest-api or whatever name we came up with - gson vs Jackson: both are in classpath, but I don't know if we're using one or both, should use one. Perhaps better suited for another PR? - endorsed lib: an endorsed lib inside web-inf allows to put APIs not included by tomcat as if tomcat itself would bundle it. JAX-RS could be placed that way, would that be useful? - openapi-generator: don't have in mind if It covers plain java to derive from the contract, but may be worth to look into WDYT? Anyway, thanks for the PR! IMO, very much needed :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
