arturobernalg opened a new pull request, #616:
URL: https://github.com/apache/jspwiki/pull/616

   DefaultUserManager.getUserProfile looked up the stored profile by wiki name, 
using the name of the user principal, which is the full name. When the full 
name has spaces it is not the wiki name, so the lookup failed, the profile was 
treated as a new one and saving an existing profile ended with "The login name 
is already taken" (reported on #566 and JSPWIKI-1361).
   
   The profile is now looked up by the login name of the session, and by the 
user principal name as before when that fails.
   
   Two tests in UserManagerTest fail without the change (profile reported as 
new, DuplicateUserException on save) and pass with it. Checked on a running 
Tomcat 10.1: with the built war, a user with the full name 'Email Test' saves 
the profile (redirect, email stored); the official 3.0.0 war gives the 'already 
taken' message for the same steps. Full reactor passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to