arturobernalg opened a new pull request, #621:
URL: https://github.com/apache/jspwiki/pull/621

   The Markdown page renderer wrote the text of a link that points to an image, 
and its url, into the alt and src attributes of the img element without 
escaping them, so a double quote in either of them ended the attribute and the 
rest of the text became attributes of the element.
   
   The values are now escaped when the attributes are written. A link to an 
image with a plain text and url is rendered as before.
   
   Three tests in MarkdownRendererTest: the text with a quote, the url with a 
quote, and a plain link. The first two fail without the change. The full build 
passes, and on a running Tomcat 10.1 with the markdown syntax a link whose text 
or url has a quote no longer adds an attribute to the img element, while the 
official 3.0.0 does.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to