arturobernalg opened a new pull request, #634:
URL: https://github.com/apache/jspwiki/pull/634

   `mvn clean test` stops at jspwiki-portable: maven-dependency-plugin:unpack 
(unpack-jspwiki-war) fails with "Artifact has not been packaged yet" (MDEP-98), 
because the module unpacks the war of the reactor in generate-resources and 
`test` does not package it. It happens with the 3.0.0 source and with the 
source of 3.0.1 RC2, and it was reported on the vote thread of RC2. The cheat 
sheet recommends `mvn clean test`.
   
   The unpacks of the war, of the wikipages and of Tomcat, and woas:copy-woas, 
now run in prepare-package, when the war exists. The dependency plugin is 
declared before antrun, so in the same phase the unpacks still run first, as 
before.
   
   Run on this change: `mvn clean test` passes in all the modules (1169 tests 
in jspwiki-main); `mvn clean package` with all the tests (1445 tests), `verify` 
and `install` pass; the woas zip of jspwiki-portable has the same SHA-256 as 
the one built before the change; the portable, with its own Tomcat, and the war 
on Tomcat 10.1 start and answer.
   
   @spyhunter99


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to