arturobernalg opened a new pull request, #638:
URL: https://github.com/apache/jspwiki/pull/638

   The integration tests read the page before the menus, the live preview or 
the page that follows a login or a save were ready, and three assumptions in 
the test setup were out of date.
   
   * The tests wait for the menus to open, for the preview to refresh and for 
the next page to load.
   * The editor refreshes its preview on input events, which setting the value 
of the field does not fire, so the test fires one.
   * The HSQL schema of the test user database gets the `oldhashes` column that 
`JDBCUserDatabase` writes.
   * The web descriptors of the test wars use the Jakarta namespace 
`WebContainerAuthorizer` looks for. With the old namespace the container 
authentication was not detected and the login of the `cma` modules failed.
   * `LoginIT` expects the login name, which is what the wiki shows for a 
logged in user.
   
   Executed on this branch, with `-Pintegration-tests` and one module at a 
time: `jspwiki-it-test-custom`, `custom-absolute-urls`, `custom-jdbc`, `cma` 
and `cma-jdbc` each run 7 tests, 0 failures. Before the change `custom` failed 
5 tests and the other modules failed 3 or 4 on the same code. `mvn clean 
package -Pintegration-tests` on the whole reactor succeeds.
   
   The CI job runs `package`, which stops before the integration-test phase, so 
these tests are not run by CI.
   
   @spyhunter99


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to