arturobernalg opened a new pull request, #641: URL: https://github.com/apache/jspwiki/pull/641
`postgresql.ddl` has never run on PostgreSQL: the column list of the `users` table ends with a comma and uses HSQL types (`longvarchar`, `varchar_ignorecase`), the commented out drops use the HSQL comment character, `create user` uses an option PostgreSQL no longer accepts, and the `oldhashes` column that `JDBCUserDatabase` writes is not defined (same gap as #639 for HSQL). The e-mail column keeps the case insensitive comparison that `findByEmail` (`WHERE email=?`) relies on, through a non deterministic ICU collation, which needs PostgreSQL 12 or later. A `citext` column was tried first: the JDBC driver sends the e-mail as text and the comparison is then case sensitive. Executed on PostgreSQL 16: the script runs without errors on an empty database and a second time on top of itself. As the `jspwiki` user, with the pgjdbc 42.7.13 driver, the INSERT of `JDBCUserDatabase` stores a user, `SELECT * FROM users WHERE email=?` finds it with the e-mail in other case, the UPDATE works and the `admin` role is read. On master the script fails on the `users` table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
