i'm baking off the build for 2.12 now. Can someone please try to figure out which of the JIRA/CVEs were updated in master-2x? We need to update CVEs to reflect that there are two fix versions for those specific issues
On Wed, Nov 18, 2026 at 6:05 AM Alex O'Ree <[email protected]> wrote: > > the sql scripts are kind of minor and we add an advisory note after the > build. something like "get the latest script here" along with a work around > for the portable build's bash script line endings. > > Let's to with it as is > > On Tue, Nov 17, 2026 at 6:09 PM Murray Altheim <[email protected]> wrote: > > > > Hi Alex, > > > > I'm never one to promote anyone else being forced to do any work, but given > > the > > changes related to the portable build I think this would be the cleanest and > > best understood approach. Whether it's actually *necessary* I leave to you. > > The > > number of people using the portable build might be very small, so possibly a > > note on building it is enough. This is an RC version after all. > > > > I probably should have mentioned that prior to my own build I did upgrade to > > Maven 3.10.1. I don't know in retrospect if that was necessary but given > > Arturo's > > experience it would seem this was not necessary. > > > > Cheers, > > > > Murray > > > > On 11/18/26 07:15, Alex O'Ree via dev wrote: > > > Revisiting given the recent PRs. > > > - one code change that fixes a database create script for user/group > > > auth via JDBC > > > - 2 additional bug fixes that resolve an open issue for the portable > > > build. > > > - a number of unit test specific fixes with no production code impacts > > > - a number of dependency updates, which probably have no production code > > > impacts > > > > > > I'm not sure if there is worth retracting RC2, applying these, then > > > processing RC3 > > > > > > Any thoughts on this? > > > > > > On Tue, Nov 17, 2026 at 1:22 PM Arturo Bernal via dev > > > <[email protected]> wrote: > > >> > > >> Hi JP, > > >> > > >> Thanks for pointing it out. You are right: the portable module needs at > > >> least "mvn package", because maven-dependency-plugin:unpack needs the > > >> packaged war (MDEP-98). I did not try Maven 3.10. > > >> > > >> To make a plain "mvn clean test" work as well, I opened > > >> https://github.com/apache/jspwiki/pull/634 for master and > > >> https://github.com/apache/jspwiki/pull/640 for master-2.x (JSPWIKI-1368). > > >> They move the unpack and the woas copy to the prepare-package phase. I > > >> ran > > >> "mvn clean test" and "mvn clean package" on both branches and both pass. > > >> I > > >> did not compare the 2.x portable zip with one built before the change. > > >> > > >> Regards, > > >> > > >> > > >> Arturo > > >> > > >> > > >> On Tue, Nov 17, 2026 at 11:15 AM Juan Pablo Santos Rodríguez < > > >> [email protected]> wrote: > > >> > > >>> Hi! > > >>> > > >>> (changing the subject in order to not pollute the vote thread) > > >>> > > >>> note that for the portable module to build, at least mvn package is > > >>> required, see > > >>> https://jspwiki-wiki.apache.org/Wiki.jsp?page=Common%20problems%20when%20building%20JSPWiki > > >>> > > >>> I'm not sure but I recall maven 3.10 may help here, the modules from > > >>> the reactor are readed differently, or taken into account before.. it > > >>> just matter of trying I guess. > > >>> > > >>> will cast my vote later on today, btw :-) > > >>> > > >>> cheers, > > >>> juan pablo > > >>> > > >>> On Tue, Nov 17, 2026 at 10:52 AM Murray Altheim <[email protected]> > > >>> wrote: > > >>>> > > >>>> Hi Arturo, > > >>>> > > >>>> I'd tried "mvn test" on a clean directory. On your suggestion I just > > >>>> did > > >>>> "mvn clean verify" and "mvn clean package" and both were successful. > > >>>> > > >>>> So with that: > > >>>> > > >>>> +1 > > >>>> > > >>>> Cheers, > > >>>> > > >>>> Murray > > >>>> > > >>>> On 11/17/26 14:20, Arturo Bernal via dev wrote: > > >>>>> Hi Murray, > > >>>>> > > >>>>> Thanks for testing. The failure is not a test: it is > > >>>>> maven-dependency-plugin:unpack in jspwiki-portable ("Artifact has not > > >>> been > > >>>>> packaged yet", MDEP-98). I get the same error with "mvn clean test", > > >>> also > > >>>>> on the 3.0.0 source. With "mvn clean verify" or "mvn clean package" > > >>> the RC2 > > >>>>> source builds completely here, and the tests pass. > > >>>>> > > >>>>> Could you tell us the exact command you ran, and try one of those two? > > >>>>> > > >>>>> Arturo > > >>>>> > > >>>>> > > >>>>> > > >>>>> > > >>>>> Arturo > > >>>>> > > >>>>> On Tue, 17 Nov 2026 at 4:34 AM, Murray Altheim <[email protected]> > > >>> wrote: > > >>>>> > > >>>>>> Unless I'm mistaken, given a test failure: > > >>>>>> > > >>>>>> -1 > > >>>>>> > > >>>>>> This is on Ubuntu 24.04.4 LTS, Java 17.0.7 and Maven 3.9.15 running > > >>> on a > > >>>>>> Dell XPS 13. > > >>>>>> > > >>>>>> I didn't notice this on the RC1 version because I may have > > >>> (accidentally) > > >>>>>> built > > >>>>>> without activating 'test'. > > >>>>>> > > >>>>>> [...] > > >>>>>> [INFO] Apache JSPWiki HTTPs War ........................... SUCCESS [ > > >>>>>> 0.042 s] > > >>>>>> [INFO] Apache JSPWiki portable ............................ FAILURE [ > > >>>>>> 1.386 s] > > >>>>>> [INFO] jspwiki-it-tests ................................... SKIPPED > > >>>>>> [INFO] jspwiki-selenide-tests ............................. SKIPPED > > >>>>>> [INFO] jspwiki-it-test-custom ............................. SKIPPED > > >>>>>> [INFO] jspwiki-it-test-custom-absolute-urls ............... SKIPPED > > >>>>>> [INFO] jspwiki-it-test-custom-jdbc ........................ SKIPPED > > >>>>>> [INFO] jspwiki-it-test-cma ................................ SKIPPED > > >>>>>> [INFO] jspwiki-it-test-cma-jdbc ........................... SKIPPED > > >>>>>> [INFO] jspwiki-test-plugin ................................ SKIPPED > > >>>>>> [INFO] Apache JSPWiki bill of materials ................... SKIPPED > > >>>>>> [INFO] > > >>>>>> > > >>> ------------------------------------------------------------------------ > > >>>>>> [INFO] BUILD FAILURE > > >>>>>> [INFO] > > >>>>>> > > >>> ------------------------------------------------------------------------ > > >>>>>> [INFO] Total time: 06:53 min > > >>>>>> [INFO] Finished at: 2026-11-17T13:34:34+13:00 > > >>>>>> [INFO] > > >>>>>> > > >>> ------------------------------------------------------------------------ > > >>>>>> [ERROR] Failed to execute goal > > >>>>>> org.apache.maven.plugins:maven-dependency-plugin:3.11.0:unpack > > >>>>>> (unpack-jspwiki-war) on project jspwiki-portable: Artifact has not > > >>> been > > >>>>>> packaged yet. When used on reactor artifact, unpack should be > > >>>>>> executed > > >>>>>> after packaging: see MDEP-98. -> [Help 1] > > >>>>>> [ERROR] > > >>>>>> [ERROR] To see the full stack trace of the errors, re-run Maven with > > >>> the > > >>>>>> -e switch. > > >>>>>> [ERROR] Re-run Maven using the -X switch to enable full debug > > >>>>>> logging. > > >>>>>> [ERROR] > > >>>>>> [ERROR] For more information about the errors and possible solutions, > > >>>>>> please read the following articles: > > >>>>>> [ERROR] [Help 1] > > >>>>>> > > >>> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > > >>>>>> [ERROR] > > >>>>>> [ERROR] After correcting the problems, you can resume the build with > > >>> the > > >>>>>> command > > >>>>>> [ERROR] mvn <args> -rf :jspwiki-portable > > >>>>>> > > >>>>>> On 11/17/26 08:57, Alex O'Ree via dev wrote: > > >>>>>>> This is a release vote for Apache JSPWiki, version 3.0.1 RC1 The > > >>>>>>> vote > > >>>>>>> will be open for at least 72 hours from now. > > >>>>>>> > > >>>>>>> It fixes the following issues: (note many of the issues have the > > >>>>>>> security flag set, so login is required to view most of them) > > >>>>>>> > > >>>>>> > > >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12357466&projectId=12310732 > > >>>>>>> > > >>>>>>> Deltas from the previous release > > >>>>>>> - 89 JIRA issues, most of them being high priority security fixes > > >>>>>>> - "Watch this page" email notifications > > >>>>>>> > > >>>>>>> Delta from RC1 > > >>>>>>> - Fixes and incomplete security fix for one of the plugins > > >>>>>>> - Updates dependency for gson > > >>>>>>> > > >>>>>>> You can see a curated changelog at > > >>>>>>> https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn3.0 > > >>>>>>> Although according to the release procedure, this is updated after > > >>> the > > >>>>>>> release is voted on and approved. > > >>>>>>> > > >>>>>>> Note that we are voting upon the source (tag), binaries are provided > > >>>>>>> for convenience. > > >>>>>>> > > >>>>>>> Everybody is encouraged to vote. > > >>>>>>> > > >>>>>>> Source and binary files: > > >>>>>>> https://dist.apache.org/repos/dist/dev/jspwiki/3.0.1-RC2 > > >>>>>>> > > >>>>>>> Nexus staging repo: > > >>>>>>> > > >>> https://repository.apache.org/content/repositories/orgapachejspwiki-1041 > > >>>>>>> > > >>>>>>> The tag to be voted upon: > > >>>>>>> https://github.com/apache/jspwiki/tree/3.0.0-RC2 > > >>>>>>> > > >>>>>>> JSPWiki's KEYS file containing PGP keys we use to sign the release: > > >>>>>>> https://www.apache.org/dist/jspwiki/KEYS > > >>>>>>> > > >>>>>>> == Reproducible Builds == > > >>>>>>> JSPWiki should follow Reproducible Builds > > >>>>>>> (https://reproducible-builds.org/). In order to verify > > >>>>>>> artifacts' build reproducibility, please use > > >>>>>>> > > >>>>>>> mvn verify artifact:compare > > >>>>>>> -Dreference.repo= > > >>>>>> https://repository.apache.org/content/repositories/staging/ > > >>>>>>> > > >>>>>>> *** Please download, test and vote: > > >>>>>>> > > >>>>>>> [ ] +1 Approve the release > > >>>>>>> [ ] 0 Don't mind > > >>>>>>> [ ] -1 Disapprove the release (please provide specific comments) > > >>>>>>> > > >>>>>>> +1 from me > > >>>>>>> > > >>>>>>> (PS expect another vote for 2.x shortly) > > >>>>>> > > >>>>>> > > >>>>> > > >>>> > > >>> > > > > >
