Hi Alex,
I'm going over the merge and have a few questions:
1. Try to stay away from reformatting files (certainly while on a
branch) - since it will mark the entire file as changed, which causes
merge issues, but it's also hard to see what changed.
2. Why did you add 'Exception' to some method signatures? for example:
throws WSDLException, JAXBException, Exception {
Now the caller is forced to catch Exception? Throwing Exception hides
granularity, and can make it harder to debug, or to catch appropriate
exceptions.
3. A lot of files got checked in with no changes. Any ideas why that
would happen? Makes it harder to see what really changed.
4. You added 2 convenience constructors in the uddi-ws module on UDDI v3
entities. One should be able to use their own UDDIv3 generated classes.
So in theory this would break that. In practice at the moment we've
added our own juddiAPI classes so we've already broken it, but I think
we should try to remove those classes at some point if possible. Also
adding javadoc to these files is nice, but if we regenerate then that
will all be last again, unless we manually add it back in.
5. Why was the change in the TCKSubscription to add the bindingKey into
the method signature and to return a String?
6. Why did you change Marshaller.JAXB_FORMATTED_OUTPUT from TRUE to
Boolean.FALSE?
7. I don't think you meant to check in the Doxyfile in the root?
8. Is the MockSSLSockFactory for testing only? Can it move to src/test?
9. I will 'mavenize' the juddi-gui module now. So you will see some
files move around to adhere to maven conventions. Also I will move the
version to 3.2.0-SNAPSHOT in the poms.
Thx for doing the merge!
Cheers,
--Kurt
