[
https://issues.apache.org/jira/browse/KAFKA-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil Ghike updated KAFKA-622:
--------------------------------
Attachment: kafka-622-v4.patch
9 - I am not convinced that "ClientIdAndTopicPartition" is the right way to
name it, because the class has 3 separate constructor arguments and it does not
use a TopicAndPartition constructor argument. Also I did not want to include
too many "And"s in the name. Let me know what you think and I can change it
accordingly.
Fixed 10, 11, 12, 13.1.
13.2 - name was used to refer to the topic name. Replaced it with a more
straightforward clientIdTopic of the type ClientIdAndTopic.
14. A more uniform scheme would be to use clientId = "client.id" in both
SyncProducerConfigShared and ConsumerConfig. This way we don't have any
confusion in using $word+"id", or $word+"_id", or $word+"Id". Similarly, we
could change groupid, consumerid in ConsumerConfig and
producer.request.correlation_id in SyncProducerConfigShared. I haven't changed
them in this patch because changing groupid might have impact on any
tools/tests that are creating consumers. Should we change them in another/this
jira?
15. Grouped object ClientId, object Topic and case class ClientIdAndTopic
together in one file ClientIdAndTopic.scala.
7. Ok.
> Create mbeans per client
> -------------------------
>
> Key: KAFKA-622
> URL: https://issues.apache.org/jira/browse/KAFKA-622
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Priority: Blocker
> Labels: bugs, improvement
> Fix For: 0.8
>
> Attachments: kafka-622-v1.patch, kafka-622-v2.patch,
> kafka-622-v3.patch, kafka-622-v4.patch
>
>
> Currently we create one mbean of each type for a given mbean server,
> regardless of the number of clients. We should create MBeans per client for
> both producer and consumer. To do that we need to introduce clientId in mbean
> names.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
